search

ge-ku / Ban-Checker-for-Steam

Ban Checker for Steam
https://chrome.google.com/webstore/detail/canbadmphamemnmdfngmcabnjmjgaiki/
107 stars 21 forks source link

Not loading matches in firefox #16

Closed IsXGeo closed 6 years ago

IsXGeo commented 6 years ago

Hello! Thanks for the awesome plugin! I am using Firefox Quantum 60.0.1 (64-bit) and plugin version 1.1.5, After adding my API key, which works successfully, I ran the plugin yet it only showed a total of eight games. It didn't change for about 10 minutes when I gave up. I tried with chrome and it worked successfully.

https://imgur.com/a/W7doHuZ

ge-ku commented 6 years ago

Simply loading matched does not use or require API key, I'm not sure why it doesn't load whole match history in Firefox for you. Can you please check if there are any errors in console when you try to replicate this?

LeoVerto commented 6 years ago

I'm having the same problem and there's nothing in the console other than the standard `` Continue token: XXX | SessionID: XXX | Profile: https://steamcommunity.com/id/xxx/

ge-ku commented 6 years ago

Please try again after updating to 1.1.7. It should give better error message.

LeoVerto commented 6 years ago

I'm getting an "Error: error parsing JSON" with the hint

"<!DOCTYPE html>\r\n<html class=\" responsive\" lang=\"en\">\r\n<head>\r\n\t<meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\">\r\n\t\t\t<meta name=\"viewport\" content=\"width=device-width,initial-scale=1\">\r\n\t\t<meta name=\"theme-color\" content=\"#171a21\">\r\n\t\t<title>Steam Community :: Leo Verto</title

and so on, which seems to be the entire HTML source of my profile page.

ge-ku commented 6 years ago

Check again using 1.1.7.1, now it should show which request caused this error, I hope it leads somewhere as currently I have no idea why it happens.

LeoVerto commented 6 years ago

Looks like it requested https://steamcommunity.com/id/leo_verto/gcpd/730?ajax=1&tab=matchhistorycompetitive&continue_token=XXX which when manually opened seemed to be valid JSON in the format

{
  "success":true,
  "html":"<table class=\"generic_kv_table csgo_scoreboard_root\">\r\n<tr>\r\n\t<th class=\"col_left\">Map<\/th>\r\n\t<th>Match Results<\/th>[SHORTENED]\r\n<\/table>\r\n",
  "continue_token":"YYY"
}

I didn't see that request in the developer console, could this be a forced redirect say because Firefox doesn't include cookies in the header of the Addon's fetch()?

ge-ku commented 6 years ago

This is likely it (though it worked for me as is), I just uploaded new version (only for Firefox for now), version is 1.1.7.2 where credentials is set to include instead of same-origin. Can you please check if it works now?

ge-ku commented 6 years ago

Finally found how to reproduce this, if I set "Accept third-party cookies" to Never it gives me this same result. I also found this topic on Mozilla Discourse where someone had this issue even with third-party cookies enabled until they launched Firefox with clean profile. Still looking for a solution.

ge-ku commented 6 years ago

Okay, another attempt :) Try it with version 1.1.8.1, it works for me even with third-party cookies disabled.

LeoVerto commented 6 years ago

Loading matches is working great now! :D I hadn't considered that an addon would be considered "third party", nicely done!