search

ge-ku / Ban-Checker-for-Steam

Ban Checker for Steam
https://chrome.google.com/webstore/detail/canbadmphamemnmdfngmcabnjmjgaiki/
107 stars 21 forks source link

Removed redundant matching for management pages #5

Closed AquaeAtrae closed 8 years ago

AquaeAtrae commented 8 years ago

Should still match both #members, /members, and /membersManage

AquaeAtrae commented 8 years ago

I'm not familiar enough with Chrome extensions to say if this constitutes version 0.6. Will it update without a version change?

ge-ku commented 8 years ago

Chrome store doesn't accept new uploads without incrementing version number. And looks like #members doesn't work for some reason.

ge-ku commented 8 years ago

Doesn't work for me, did you test it? I also tried to use "include_globs" and it just doesn't work for me with a "#" sign. I assume the reason is that it doesn't reload whole page. I'll push an update with a workaround that just replaces all links that contains "#members" with "/members" on /gropus/ pages. Feel free to make it more elegant/efficient and/or make it work like "#members" pages, without reloading whole page.

AquaeAtrae commented 8 years ago

Sorry, I've been busy with paid work today. But I nearly solved the issue for the #members page which is loaded by AJAX. My folk waits for the content on that page now, but I'm now looking for an event hook to activate again when moving to page 2, page 3, etc. I'll send another pull request when I've figured it all out.

Thanks again for all your support with this tool.

Doug - The long-haired red-headed guy with glasses

On Tue, Feb 23, 2016 at 8:06 AM, ge-ku notifications@github.com wrote:

Doesn't work for me, did you test it? I also tried to use "include_globs" and it just doesn't work for me with a "#" sign. I assume the reason is that it doesn't reload whole page. I'll push an update with a workaround that just replaces all links that contains "#members" with "/members" on /gropus/ pages. Feel free to make it more elegant/efficient and/or make it work like "#members" pages, without reloading whole page.

— Reply to this email directly or view it on GitHub https://github.com/ge-ku/Ban-Checker-for-Steam/pull/5#issuecomment-187732724 .

ge-ku commented 8 years ago

Check this (first 30 strings), it detects when #members page clicked or opened. You can insert your function where "check bans when loaded" comments are.

AquaeAtrae commented 8 years ago

I'll look at this more closely, but I suspect it overrides Steam's BindOnHashChange() found in global.js, line 770. Not yet clear what consequences that might have.

That's why I thought we'd have to find another event hook. Or perhaps we could override and augment the BindOnHashChange function. That would seem best.