ge0rg / libmpq

Libmpq is a library for reading MPQ files (archives used by Blizzard) which can be easily used in applications.
https://libmpq.org/
GNU General Public License v2.0
75 stars 14 forks source link

Compilation warning: taking address of packed member #3

Open glebm opened 3 years ago

glebm commented 3 years ago

Not sure if benign or not:

_deps/libmpq-src/libmpq/mpq.c: In function ‘libmpq__block_open_offset’:
_deps/libmpq-src/libmpq/mpq.c:696:128: warning: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  696 |    if (libmpq__decrypt_key((uint8_t *)mpq_archive->mpq_file[file_number]->packed_offset, packed_size, mpq_archive->block_size, &mpq_archive->mpq_file[file_number]->seed) < 0) {
      |                                                                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ge0rg commented 3 years ago

Hey, it's great that you've taken up the lib after a decade! I've never been a maintainer myself, I just contributed a bit of code to it, and @mbroemme is the owner - and https://github.com/mbroemme/libmpq/ is the master repository. This fork is so old that github doesn't even show it as a fork ;)

If you want to contribute, I fear it's the best way to re-open all of the issues on the @mbroemme repository. Please let me know when you've done it and I'll close the issues and disable issues / PRs on this clone. Thanks and sorry for the additional work needed.

glebm commented 3 years ago

Ah, I see, thanks for replying. I've now reopened all the PRs in @mbroemme repository. Feel free to archive the repository with a big note pointing to mbroemme/libmpq.

mbroemme commented 3 years ago

@glebm Thanks for all the PRs, I will review them the next days in original repository.