search

geany / geany-plugins

The combined Geany Plugins collection
http://plugins.geany.org/
581 stars 262 forks source link

ProjectOrganizer, Workbench: Use GStatBuf for "g_stat()" calls #1353

Closed eht16 closed 1 month ago

eht16 commented 1 month ago

For some reason, since the latest MSYS2 update on my Windows system, I got compiler errors that g_stat() requires a GStatBuf type as second argument.

According to the docs, https://docs.gtk.org/glib/func.stat.html, this is correct and in Geany we also use GStatBuf in all places.

elextr commented 1 month ago

For some reason, since the latest MSYS2 update on my Windows system, I got compiler errors that g_stat() requires a GStatBuf type as second argument.

On windows there are many MS stat calls and struct stat is a structure that changes depending on platform, compiler, target os, wind direction etc and in some cases may not match g_stat which calls only one of the many MS stat calls. Perhaps they could have made g_stat() call the right function for the definition of struct stat but probably it was easier to define GStatBuf to match the MS call made by g_stat(). Maybe which MS call g_stat() uses changed, it was 32 bit times IIRC and maybe they finally switched to 64 bit ones, so its good the compiler now enforces it.

LGBI