search

geany / geany-themes

A collection of color schemes for Geany
Other
351 stars 123 forks source link

Metallic Bottle: use a slightly darker background color for selections #71

Open eht16 opened 4 months ago

eht16 commented 4 months ago

I just made the background color for selections a little darker so that it is different from the foreground color.

Closes #70.

Screenshot

eht16 commented 3 months ago

If there are no objections or improvement suggestions, I would like to merge to this in a week.

b4n commented 3 months ago

I think the gray strings are a bit hard to read on that brown, but I have no opinion apart that the mentioned bug is indeed bad, and if this fixes it, good :)

eht16 commented 1 month ago

@b4n they are indeed. I gave #e4d3c7 it try as a rather lighter brown than before. Screenshot_2024-05-20_17-12-06

This might be better for selection background. Though this makes the braces and the ... in the varags of the function definition harder to read.

I'm really bad at colors :(.

@rovf since you reported it and obviously are using this theme, do you have any preference or a better alternative?

b4n commented 1 month ago

Better, but what about #ebdfd8? metallic-bottle-ebdfd8

Still not great for readability, but a tad better and the whole theme doesn't focus on contrast it seems.

Not that I care, it's indeed better to get input from actual theme users :slightly_smiling_face:

eht16 commented 1 month ago

#ebdfd8 seems fine to me.

Let's see what @rovf says.