search

geany / geany

A fast and lightweight IDE
https://www.geany.org
GNU General Public License v2.0
3.15k stars 608 forks source link

Add themes from geany-themes #4044

Open techee opened 1 week ago

techee commented 1 week ago

This patch:

Fixes #4035.

eht16 commented 1 week ago

Looks good, great!

eht16 commented 1 week ago

To be more verbose: the licensing is annoying but the solution here using an allowlist is pretty good and it's nice that we already get almost all themes included.

Thanks for digging through all the themes and put up the list.

After we have merged this, we could add a note to the geany-themes repo's README to show that the themes with compatible license are included semi-automatically.

Is it worth adding a note to doc/making-a-release?

techee commented 1 week ago

To be more verbose: the licensing is annoying but the solution here using an allowlist is pretty good and it's nice that we already get almost all themes included.

I just hope it's alright license-wise - for instance that a GPL 3 theme doesn't require that all Geany sources are GPL 3. But I'd say that since themes are completely independent of the rest of the Geany, loaded at the runtime in the source form, and non-essential for running Geany, they don't affect the license of Geany itself. Am I right?

After we have merged this, we could add a note to the geany-themes repo's README to show that the themes with compatible license are included semi-automatically.

Agree.

Is it worth adding a note to doc/making-a-release?

I'll try to update it.

I also created https://github.com/geany/geany-themes/pull/77 so geany-themes contains all the external theme files - I just don't know what to use as its license and who is the author of that theme.

eht16 commented 6 days ago

To be more verbose: the licensing is annoying but the solution here using an allowlist is pretty good and it's nice that we already get almost all themes included.

I just hope it's alright license-wise - for instance that a GPL 3 theme doesn't require that all Geany sources are GPL 3. But I'd say that since themes are completely independent of the rest of the Geany, loaded at the runtime in the source form, and non-essential for running Geany, they don't affect the license of Geany itself. Am I right?

I think yes but I'm not sure at all. @frlan do you know who we could ask? Someone from FSFE maybe?

Is it worth adding a note to doc/making-a-release?

I'll try to update it.

Thanks.

I also created geany/geany-themes#77 so geany-themes contains all the external theme files - I just don't know what to use as its license and who is the author of that theme.

Great, I answered there.

techee commented 6 days ago

I just hope it's alright license-wise - for instance that a GPL 3 theme doesn't require that all Geany sources are GPL 3. But I'd say that since themes are completely independent of the rest of the Geany, loaded at the runtime in the source form, and non-essential for running Geany, they don't affect the license of Geany itself. Am I right?

I think yes but I'm not sure at all.

On the other hand in the worst case scenario that theme licenses affect Geany's license as a whole, I think we only have to deal with a single theme - the GPLv3 theme epsilon. Based on

https://www.gnu.org/licenses/gpl-faq.en.html#AllCompatibility

LGPLv2.1 code can be either "copied" to GPLv2 (and the result is GPLv2) or "used as a library" without any restriction - not sure which of the two things we do with themes but we should be fine.

I also searched for the difference between LGPLv2 (which most of the themes use) and LGPLv2.1 and made a diff of those and it's mostly renaming it from "GNU Library General Public License" to "GNU Lesser General Public License" and some minor wording so I think the table above is valid for LGPLv2 too as well.

So I think for now I could just move the GPLv3 theme to the ignored ones and keep the rest - I believe we should be fine.

dmaphy commented 5 days ago

So in Fedora we have two packages, one called geany and one called geany-themes. I see problems coming when both packages are trying to install the same file. Not sure yet on how to solve this, my current idea is to add a functionality to disable this feature at build time. How do you think about this?

eht16 commented 5 days ago

So in Fedora we have two packages, one called geany and one called geany-themes. I see problems coming when both packages are trying to install the same file. Not sure yet on how to solve this, my current idea is to add a functionality to disable this feature at build time. How do you think about this?

After this PR a seperate geany-themes package is probably not necessary anymore. Only the themes with incompatible or missing licenses will be missing but we can try to relicense resp. add missing licenses and then include those themes too.

When talking about distributions with geany-themes packages: how did you solve the licensing problem? @dmaphy @matt-h @Digital-Chaos

dmaphy commented 5 days ago

So in Fedora we have two packages, one called geany and one called geany-themes. I see problems coming when both packages are trying to install the same file. Not sure yet on how to solve this, my current idea is to add a functionality to disable this feature at build time. How do you think about this?

After this PR a seperate geany-themes package is probably not necessary anymore. Only the themes with incompatible or missing licenses will be missing but we can try to relicense resp. add missing licenses and then include those themes too.

Good, so the plan would be to obsolete the geany-themes package. That's something I can work with in Fedora. (:

When talking about distributions with geany-themes packages: how did you solve the licensing problem? @dmaphy @matt-h @Digital-Chaos

Just checked for the Fedora package. Most colorschemes there are (L)GPLv2+ or BSD licensed. Actually there could be issues with the monokai.conf, gotta clarify the situation or remove that one when I get around to it.

techee commented 4 days ago

(I accidentally pushed this 'themes' branch to the geany repo instead of my fork. I've already deleted this branch.)