Breaking change in Laravel v10.3

gearbox-solutions / eloquent-filemaker

A Model extension and Eloquent driver for Laravel connecting to FileMaker through the Data API

https://gearboxgo.com

MIT License

54 stars 16 forks source link

Breaking change in Laravel v10.3 #42

Closed lgebing closed 1 year ago

lgebing commented 1 year ago

Hi, I just encountered the following error after upgrading to the newest Laravel version (10.3):

Declaration of GearboxSolutions\EloquentFileMaker\Database\Query\FMBaseBuilder::paginate($perPage = 15, $columns = [...], $pageName = 'page', $page = null) must be compatible with Illuminate\Database\Query\Builder::paginate($perPage = 15, $columns = [...], $pageName = 'page', $page = null, $total = null)

Problem is this PR which added a new parameter total to the paginate function.

lgebing commented 1 year ago

As it looks like this is getting reverted I'm going to close this issue. Maybe something to keep in mind for the future.