Fix logic of where method to work with whereNot

gearbox-solutions / eloquent-filemaker

A Model extension and Eloquent driver for Laravel connecting to FileMaker through the Data API

https://gearboxgo.com

MIT License

54 stars 16 forks source link

Fix logic of where method to work with whereNot #50

Closed likeadeckofcards closed 5 months ago

likeadeckofcards commented 1 year ago

This PR adjusts the functionality of where method to make the method handle the boolean values set by whereNot method in Laravel's default builder classes.

Fixes #49

Smef commented 1 year ago

override Eloquent/Builder.php applyScopes()

loop through each find and apply the scope to include requests
(skip over omits)
if we find no include finds, we should apply the scope

in where handler for FMBaseBuilder

if the new find is a where
add the find criteria to the last include or make a new include before the omits
if the new find is an whereNot(omit), add a new omit request,

Smef commented 5 months ago

This was merged into 2.0.