search

gearman / gearmand

http://gearman.org/
Other
741 stars 138 forks source link

#230 gearman_wait don't ignore signal by flag #231

Open borro opened 5 years ago

borro commented 5 years ago

interrupt in gearman_wait function after signal arrive

esabol commented 5 years ago

Looks promising!

How about a test case?

borro commented 5 years ago

How about a test case?

I am not a C++ programmer. I just made corrections in the code in an analogy, so that they look like yours. Writing unit tests in C++ is already above my knowledge.

SpamapS commented 5 years ago

@borro thanks, I understand where you're at. We may need to follow-up with a test case before we land this.

A test case could be tricky though, as we'll need to add signals to the test suite, which I'm not sure are in there, or we need to add an integration test that spins up gearmand and ensures it handles signals that way.

For now, does anyone want to try and figure out how to test this bit in the regular test suite?

SpamapS commented 4 years ago

Bumping this a bit. Seems useful for usre, but I'd still like to see a test. However, it seems nobody has found the time to figure that out. This adds an API call, so I wonder if we should consider bumping to 1.2.0 if we merge.

SpamapS commented 1 year ago

Hi @borro . Could you please file a separate issue that clearly explains the need for this? I converted it to a Draft PR for now ,so we're not confused by the fact that it's not really ready.

borro commented 1 year ago

@SpamapS all descriptions in Issue #230. I repeat that I am not a C++ developer and have no idea how to write unit tests for C++ and signal processing.