search

gearman / gearmand

http://gearman.org/
Other
740 stars 137 forks source link

Fix bug in prioritystatus #338

Closed SpamapS closed 2 years ago

SpamapS commented 2 years ago

This has never been correct, and has only ever shown 1 if there are any in a priority, or 0 if there are not. That is because the next struct field that as used is confusingly not maintained in this context.

Closes #337

esabol commented 2 years ago

Thanks, @SpamapS ! Looks good. Simple enough fix. Do you have time to add a test for this? If not, I'm cool with just merging it.

P.S. Can you remove Travis CI from the required checks? It's just impeding things at this point.

SpamapS commented 2 years ago

I tried to add some tests and got frustrated with C/C++ in general but I'll take another swing at it tonight. And yeah I'll look at the Travis situation too.

On Wed, Jun 1, 2022, 3:20 PM Ed Sabol @.***> wrote:

Thanks, @SpamapS https://github.com/SpamapS ! Looks good. Simple enough fix. Do you have time to add a test for this? If not, I'm cool with just merging it.

P.S. Can you remove Travis CI from the required checks? It's just impeding things at this point.

— Reply to this email directly, view it on GitHub https://github.com/gearman/gearmand/pull/338#issuecomment-1144200156, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS6YEICNVK2J7WC32BULTVM7O2NANCNFSM5XPRU55Q . You are receiving this because you were mentioned.Message ID: @.***>