search

gearman / gearmand

http://gearman.org/
Other
727 stars 138 forks source link

Additional refinements to GitHub Actions CI workflow #354

Open esabol opened 1 year ago

esabol commented 1 year ago

Now that PR #334 has been merged, I'd like to see the following enhancements to the GitHub Actions CI workflow:

  1. Add builds for different versions of clang.
  2. Add at least one build on macOS.
  3. Add a build for Alpine 3.17, which uses gcc 12. Attempted in PR #362, but tests segmentation fault inside the GitHub Actions Alpine 3.17 container (but not in Docker on my system).
  4. Maybe add at least one build on Debian? A Dockerfile for building gearmand on Debian would be helpful for this.
  5. Rename the .github/workflow/c-cpp.yml file to the far more common name ci.yml. Done in PR #363.
  6. Change uses: actions/checkout@v2 to uses: actions/checkout@v3 (or uses: actions/checkout@main to always use the latest checkout action?) to eliminate the Node.js 12 actions are deprecated. warning we are now getting. Done in PR #360.
  7. Add CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" to the gcc 9 (and higher??) build(s). Done in PR #361.

If anyone wants to help with these, I'd appreciate it!

esabol commented 1 year ago

The 1.1.20 release notes reminded me of a change to the Travis CI that didn't get implemented in the GitHub Actions CI:

CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" should be added to gcc 9 (and higher??) builds.

esabol commented 1 month ago

Ubuntu 24.04 is out, so probably should add that to the CI. Also new versions of gcc have been released as well.

esabol commented 1 month ago

Ubuntu 24.04 is out, so probably should add that to the CI.

Apparently, GitHub hasn't added Ubuntu 24.04 runners yet. I'm surprised.

https://github.com/github/roadmap/issues/958

So I think we need to use a container instead:

https://github.com/actions/runner-images