gearman / gearmand

http://gearman.org/
Other
727 stars 138 forks source link

Added CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" to gcc-9 and higher builds in GitHub Actions CI #361

Closed esabol closed 1 year ago

esabol commented 1 year ago

This pull request partially addresses issue #354 by restoring CXXFLAGS="-Wp,-D_GLIBCXX_ASSERTIONS" to the gcc-9 and higher builds in GitHub Actions CI. This was previously in the Travis CI, but I forgot to include it in the transition to GitHub Action CI. The gcc documentation says that it "enables extra error checking in the form of precondition assertions, such as bounds checking in strings and null pointer checks when dereferencing smart pointers." This was useful in finding multiple errors in the gearmand source code in the past.