search

gearman / gearmand

http://gearman.org/
Other
727 stars 138 forks source link

Configure error when gperf is absent #376

Closed ntrs closed 9 months ago

ntrs commented 9 months ago

If configure script cannot find gperf, it ends up with an error (at least on FreeBSD 13.2):

checking for gperf... no
./configure: 22415: Syntax error: Bad fd number

The line 22415 looks like this: > as_fn_error $? "could not find gperf" "$LINENO" 5]

There is a square bracket at the end of line, which seems to be doubled by mistake in configure.ac line 128:

https://github.com/gearman/gearmand/blob/56761cd7c6119cbfde81033f3371a551055390a3/configure.ac#L128

esabol commented 9 months ago

OK, so if you remove that extra square bracket, does it fix the error, @ntrs?

ntrs commented 9 months ago

@esabol, yes, configure doesn't stop at that point when I remove it.

esabol commented 9 months ago

@esabol, yes, configure doesn't stop at that point when I remove it.

Great catch! Do you want to submit a pull request?

ntrs commented 9 months ago

Great catch! Do you want to submit a pull request?

I'm too lazy to learn how to do all that push/pull/sense/heal stuff :) Maybe you could just hit DEL once when editing that file before next release...

esabol commented 9 months ago

I'm too lazy to learn how to do all that push/pull/sense/heal stuff :)

OK, I’ll do it. Just wanted to give you the option since you found the problem and the fix. :smile: