Is gearmand using getservbyname() correctly?

esabol commented 2 months ago

libgearman-server/plugins/protocol/gear/protocol.cc#L468 says:

      gearman_servent= getservbyname(GEARMAN_DEFAULT_TCP_SERVICE, NULL)
      service= gearman_servent->s_name;
      _port.append(service);

The s_name parameter is the name of the service, I believe?

Should gearmand be using the servent property _port instead of _name?

SpamapS commented 2 months ago

No, it's a bit confusing, but I think the idea here is we look it up and turn it into a port later in the startup, so we're just looking up the name in case the system has a different one aliased for gearman.

On Wed, Sep 18, 2024 at 4:19 PM Ed Sabol @.***> wrote:

libgearman-server/plugins/protocol/gear/protocol.cc#L468 https://github.com/gearman/gearmand/blob/728f3a5ab58c2a580481e0a4f60f2316a6981ecf/libgearman-server/plugins/protocol/gear/protocol.cc#L468 says:
  gearman_servent= getservbyname(GEARMAN_DEFAULT_TCP_SERVICE, NULL)
  service= gearman_servent->s_name;
  _port.append(service);
The s_name parameter is the name of the service, I believe?

Should gearmand be using the servent property _port instead of _name?

— Reply to this email directly, view it on GitHub https://github.com/gearman/gearmand/issues/412, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS6YCNF73FXMDG22R6HHDZXIC7BAVCNFSM6AAAAABOOWVPCSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUZTIOJTGQYTGMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

esabol commented 2 months ago

Really? That seems very weird to me. Guess I'll close this an a non-issue then.

gearman / gearmand

Is gearmand using getservbyname() correctly? #412