search

gearsandcode / protractor-axe-html-report-plugin

Generates an aXe accessibility report in HTML
MIT License
3 stars 5 forks source link

ability to define custom html report file name #16

Closed github1 closed 4 years ago

github1 commented 4 years ago

Hey @gearsandcode - this PR handles essentially the same use case as #15 (set own htmlReportFilename), but is a little more flexible because it allows you to provide a template for the file name.

github1 commented 4 years ago

Why the package change?

That was inadvertent. I had published a scoped package of my fork and just forgot to change it back.

gearsandcode commented 4 years ago

Ugh. I merged this blindly, but looks like I might need to update the documentation. npm start now requires a port and I'm getting an error from Puppeteer. Any ideas? I had to revert it for the time being.

npm start -p 4200

protractor-axe-html-report-plugin@1.1.3 start /Users/jesse/Source/protractor-axe-html-report-plugin httpster -d testapp/ -p node -p 'process.env.HTTP_PORT || require("./spec/environment").webServerDefaultPort' "4200"

/Users/jesse/Source/protractor-axe-html-report-plugin/node_modules/puppeteer/lib/cjs/puppeteer/common/Puppeteer.js:94 launch(options = {}) { ^

SyntaxError: Unexpected token = at exports.runInThisContext (vm.js:53:16) at Module._compile (module.js:373:25) at Object.Module._extensions..js (module.js:416:10) at Module.load (module.js:343:32) at Function.Module._load (module.js:300:12) at Module.require (module.js:353:17) at require (internal/module.js:12:17) at Object. (/Users/jesse/Source/protractor-axe-html-report-plugin/node_modules/puppeteer/lib/cjs/puppeteer/initialize.js:22:24) at Module._compile (module.js:409:26) at Object.Module._extensions..js (module.js:416:10)

github1 commented 4 years ago

What version of node are you using?

gearsandcode commented 4 years ago

That'd be 4.4.1 facepalm

I need to do more dev work not on my work laptop apparently.