search

gearsandcode / protractor-axe-html-report-plugin

Generates an aXe accessibility report in HTML
MIT License
3 stars 5 forks source link

Update axe-webdriverjs, to also get newer version of axe-core #8

Closed brendan-donegan closed 6 years ago

brendan-donegan commented 6 years ago

I'd like to propose updating the axe-webdriverjs dependency to the latest version of 2.0.1. This will also pull in the latest version of axe-core which has a variety of new rules, features and fixes. I also removed the listed dependency on axe-core as it doesn't do anything - the report is generated with rules from the version of axe-core that axe-webdriverjs depends on.

gearsandcode commented 6 years ago

Thanks for your contribution!

brendan-donegan commented 6 years ago

Hi Jesse,

Thanks for accepting my PR! Is the package republished in NPM automatically?

On Mon, 5 Nov 2018, 5:14 am Jesse Clark <notifications@github.com wrote:

Merged #8 https://github.com/gearsandcode/protractor-axe-html-report-plugin/pull/8 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gearsandcode/protractor-axe-html-report-plugin/pull/8#event-1945329081, or mute the thread https://github.com/notifications/unsubscribe-auth/ACS2LutJ1WKPst9QElhkWy-dsr951HCZks5ur8kugaJpZM4YM7Kl .

gearsandcode commented 6 years ago

@brendan-donegan - Not automatically, no. However I did a version bump and an NPM publish. Your changes are available on version 0.1.0. See: https://www.npmjs.com/package/protractor-axe-html-report-plugin

brendan-donegan commented 6 years ago

That's awesome, thanks! Just updating our infrastructure to use the newer version

On Mon, 5 Nov 2018, 7:10 pm Jesse Clark <notifications@github.com wrote:

@brendan-donegan https://github.com/brendan-donegan - Not automatically, no. However I did a version bump and an NPM publish. Your changes are available on version 0.1.0. See: https://www.npmjs.com/package/protractor-axe-html-report-plugin

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gearsandcode/protractor-axe-html-report-plugin/pull/8#issuecomment-435997770, or mute the thread https://github.com/notifications/unsubscribe-auth/ACS2Lk3OaT-W_Z4Ya1kvTX33tRL2Tm4Oks5usI0YgaJpZM4YM7Kl .

gearsandcode commented 6 years ago

I'll be releasing 1.1.1 later today I hope. It just adds some missing typings and gets the versioning back in line with the Github release.