search

gearsdigital / enhanced-toolbar-link-dialog

Extend Kirby's default link dialog with search functionality, allowing you to easily create links to existing or external pages at your fingertips.
MIT License
62 stars 8 forks source link

Impact on kirby modal height #84

Closed batgithub closed 1 year ago

batgithub commented 1 year ago

Hi, thanks for your plugin that add a really good feature to kirby 🙂.

My issue is that your plugin impact the height of the general modal of kirby (for changing status, name ...)

I found that there is a min-height: in EnhancedToolbarWriterLinkDialog.vue that may cause this issue. .k-dialog-body form { min-height: 340px; } Is there any reason to add this ? Because without this property it seems to work too ?

How it looks normally Capture d’écran 2023-03-09 à 13 11 25

how it's altered by the plugin Capture d’écran 2023-03-09 à 13 08 35

gearsdigital commented 1 year ago

@batgithub It's been a while... Sorry mate! 🙈 Anyhow, thank you very much for bringing this to my attention.

Pretty sure there was a reason once but to be honest, I can't remember ^^ It seems everything works as expected despite I've removed the conflicting styles.

I guess that was a quick win?

gearsdigital commented 1 year ago

:tada: This issue has been resolved in version 3.1.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: