geary / google-election-center-data

Automatically exported from code.google.com/p/google-election-center-data
0 stars 0 forks source link

Gadget should display location name/address on geocode fail #17

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What is the address that you searched for?
3658 madison ave kansas city mo

Here's the original request

(a) When the gadget gets address line 1, city, state, and zip
(optionally, location name and address line 2) *and* it geocodes,
return result

(b) When the gadget gets location name but not a complete address
(i.e., not street name, city, etc), replace city and state with the
voters city and state (I don't think we should do the same with zip,
but you're the experts), and try to geocode. If geocodes within 5
miles of voters' address, sucess; if not, report location name and any
address info but do not map.

(b2) If address info is complete and that address does not geocode, return 
address info to user without map.

(c) When provided with (i) nothing,  (ii) only state, or (iii) a
partial (non-geocoding) address and no location name, then give up.

Original issue reported on code.google.com by aaro...@gmail.com on 19 Oct 2010 at 6:16

GoogleCodeExporter commented 9 years ago
Issue 18 has been merged into this issue.

Original comment by aaro...@gmail.com on 19 Oct 2010 at 6:21

GoogleCodeExporter commented 9 years ago

Original comment by aaro...@gmail.com on 19 Oct 2010 at 6:21

GoogleCodeExporter commented 9 years ago

Original comment by aaro...@gmail.com on 19 Oct 2010 at 6:21

GoogleCodeExporter commented 9 years ago

Original comment by mike%gea...@gtempaccount.com on 19 Oct 2010 at 6:52

GoogleCodeExporter commented 9 years ago
Fixed: 
http://code.google.com/p/election-gadgets/source/detail?r=098b9bc178a2bea533249a
43c292c5ec4c3a43eb

I didn't do the mix and match logic in (b) - that seems a bit risky - I simply 
don't try to geocode the polling place when there's no address in the API 
result. If that doesn't seem adequate we can take a look at the fancier logic.

Original comment by mike%gea...@gtempaccount.com on 19 Oct 2010 at 7:54

GoogleCodeExporter commented 9 years ago
Is this live? I don't see the location address for 5431 Forest Ave Kansas City, 
MO 64110, though I see a blank spot where the address should be...

Original comment by aaro...@gmail.com on 19 Oct 2010 at 7:59

GoogleCodeExporter commented 9 years ago
Still nothing for 3658 Madison Ave Kansas City, MO 64111
or
5431 Forest Ave Kansas City, MO 64110

Original comment by aaro...@gmail.com on 20 Oct 2010 at 3:13

GoogleCodeExporter commented 9 years ago
3658 Madison Ave Kansas City, MO 64111 returns a polling location with no 
location name, but this should still work:
{"status":"SUCCESS","locations":[[{"dataset_id":688,"election_id":2,"id":
        "688:5500025570239","address":{"line1":
          "7600 LEE\u0027S SUMMIT RD  OVERFLOW AREA-EAST","city":
          "KANSAS CITY","state":"MO","zip":"64139"},"directions":"",
        "polling_hours":""}]],"contests":[[]]}

I *suspect* it's the wonderful unicode character after LEE, but i don't know

Original comment by dan...@google.com on 20 Oct 2010 at 6:48

GoogleCodeExporter commented 9 years ago
No unicode character here though:

http://pollinglocation.apis.google.com/?q=5431%20Forest%20Ave%20Kansas%20City,%2
0MO%2064110
{"status":"SUCCESS","locations":[[{"dataset_id":688,"election_id":2,"id":
        "688:5500025570324","address":{"line1":
          "1600 E. 58TH ST  FELLOWSHIP HALL","city":"KANSAS CITY","state":
          "MO","zip":"64110"},"directions":"","polling_hours":""}]],
  "contests":[[]]}

Original comment by aaro...@gmail.com on 22 Oct 2010 at 4:04

GoogleCodeExporter commented 9 years ago
The problem with these are the line1 values:

"line1": "1600 E. 58TH ST  FELLOWSHIP HALL"

"line1": "7600 LEE\u0027S SUMMIT RD  OVERFLOW AREA-EAST"

and this similar one:

"line1": "3601 ROANOKE RD MEETING ROOM"

These are causing confusion when I geocode the resulting address. I'm giving 
the geocoder an address like this:

3601 ROANOKE RD MEETING ROOM, KANSAS CITY, MO 64111

And when that geocodes it comes back with an Accuracy level of 5 (zip code)

Why do these line1 values have things like FELLOWSHIP HALL in them? Did that 
get mixed in from another data field or was it in the original data like that?

Original comment by mike%gea...@gtempaccount.com on 26 Oct 2010 at 7:05

GoogleCodeExporter commented 9 years ago
Why? Because political data is a mess.  These are feed entries so we don't 
touch them as they come right from the election official.

Can we display the written info when accuracy is only level 5?

Original comment by aaro...@gmail.com on 26 Oct 2010 at 1:41

GoogleCodeExporter commented 9 years ago
I think this is fixed with my recent updates. Both the addresses mentioned now 
display the polling place name even though we can't map it.

Original comment by mike%gea...@gtempaccount.com on 1 Nov 2010 at 6:24