geary / google-election-center-data

Automatically exported from code.google.com/p/google-election-center-data
0 stars 0 forks source link

Gadget needs sanity check #47

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
42 merry lane Westbury NY
http://pollinglocation.apis.google.com/?q=42%20merry%20lane%20Westbury%20NY

Location geocodes to PA! (Because polling location doesn't have city).

We need a sanity check in miles for the gadget -- I'm pretty sure we've had 
this in prior cycles

Original issue reported on code.google.com by aaro...@gmail.com on 29 Oct 2010 at 2:28

GoogleCodeExporter commented 9 years ago
Looking at this address, it's NOI data and we didn't parse the city out from 
the address.  We are working to correct any parsing issues now, and will have 
an updated file to Google this evening.  

Original comment by anthea.w...@gmail.com on 29 Oct 2010 at 3:28

GoogleCodeExporter commented 9 years ago
In addition to sanity check, would recommend to Geary that you concatenate all 
of the polling location fields before geocoding if possible. There's a similar 
bug in Sarasota with the vendor mixing up line1 and line2 in polling location.

5177 RIVERWOOD AVE SARASOTA FL 34231

Original comment by aaro...@gmail.com on 29 Oct 2010 at 6:20

GoogleCodeExporter commented 9 years ago
I fixed the problem with the Sarasota address. Your suspicion was close - I was 
already putting both line1 and line2 in the geocode request, but there was a 
sanity test ahead of that, which bypassed the geocoding entirely if line1 was 
empty. Oops.

I get a NO_STREET_SEGMENT error with the Westbury address:

http://election-gadgets.googlecode.com/hg/voter-info/voter-info.html#%23address%
3D!42%2520merry%2520lane%2520Westbury%2520NY

It doesn't seem to be a line1/line2 issue, it never gets that far.

Also, this bug tracker is public. I think we had better not put people's home 
addresses in it. Maybe we'll need to coordinate those kinds of bugs by email 
instead? In fact I will delete this issue after you've had a look at it.

Original comment by mike%gea...@gtempaccount.com on 30 Oct 2010 at 2:41