gearz-lab / react-ui

Bootstrap based data components for React
http://reactui.com
MIT License
13 stars 1 forks source link

Repository structure and contents #2

Open masbicudo opened 9 years ago

masbicudo commented 9 years ago

What is all that stuff in the repository?

HTML5 boiler plate

I don't think that HTML5 boiler plate should be in the root of this project. I don't think it should be in this project in the first place.

If we want to make a site with live samples, we could make a github page, and commit HTML5 boiler plate there instead.

Also when creating an issue this appears at top, caused by the existence of CONTRIBUTING.md:

image

.idea

What are these files?

They seem to be some kind of cached information from a tool that you might be using. Please, don't commit them if you don't think these files should be shared with others.

In some projects I commit Resharper .DotSettings files and Settings.StyleCop. They are coding style settings that I want to share with other developers. If these .idea files have this purpose then I think it is ok, but by looking at their contents, it doesn't appear to be that.

Structure

Here is a structure that fulfils the purpose of this repository:

Notes:

Thoughts?

andrerpena commented 9 years ago

I agree. Except that I would put the components inside a src folder because it seems like there's a tool called gulp that is widely used and it allows you to compile your code into a dist folder.

andrerpena commented 9 years ago

I'm including the .idea folder in the .gitignore

masbicudo commented 9 years ago

Nice, I totally agree.