Open masbicudo opened 9 years ago
I agree. Except that I would put the components inside a src
folder because it seems like there's a tool called gulp
that is widely used and it allows you to compile your code into a dist
folder.
I'm including the .idea folder in the .gitignore
Nice, I totally agree.
What is all that stuff in the repository?
HTML5 boiler plate
I don't think that HTML5 boiler plate should be in the root of this project. I don't think it should be in this project in the first place.
If we want to make a site with live samples, we could make a github page, and commit HTML5 boiler plate there instead.
Also when creating an issue this appears at top, caused by the existence of
CONTRIBUTING.md
:.idea
What are these files?
They seem to be some kind of cached information from a tool that you might be using. Please, don't commit them if you don't think these files should be shared with others.
In some projects I commit Resharper
.DotSettings
files andSettings.StyleCop
. They are coding style settings that I want to share with other developers. If these.idea
files have this purpose then I think it is ok, but by looking at their contents, it doesn't appear to be that.Structure
Here is a structure that fulfils the purpose of this repository:
components\
- only the code of our components: scripts and styles made by ourselvesdefault\
- the default presentation structure (our own)pager.jsx
- the pager component rendered with our own structureskins\
- skins for our presentational structurelight\
- light themed skinpager.css
- skin for the pager componentdark\
- dark themed skinpager.css
- skin for the pager componentbootstrap-3\
- components using the bootstrap-3 presentation frameworkpager.jsx
- pager component rendered for bootstrap-3skins\
- shouldn't exist, since bootstrap has it's own skinssamples\
- samples of component usagepager-basic-samples\
pager-default.html
- sample using the pagerpager-bootstrap-3.html
- sample using the pager with bootstrap-3 structure... the code is the same as the above file, but including the corresponding pager.jsx filepager-sample.js
- script compatible with both structures (because they can be swapped)Notes:
components\default\pager.jsx
andcomponents\bootstrap-3\pager.jsx
behave exactly the same, only the HTML structure is different between them.Thoughts?