gebirgslok / BricklinkSharp

Easy-to-use C# client for the bricklink (LEGO) marketplace API.
https://github.com/gebirgslok/BricklinkSharp
MIT License
28 stars 12 forks source link

request handler added #19

Closed stephanstapel closed 1 year ago

stephanstapel commented 1 year ago

I took the recommandation from #17 and did a straight-forward implementation.

I implemented it a simpler manner, not passing the request and response objects. Looking forward to your comments!

stephanstapel commented 1 year ago

The code needs a couple change to make the async hook work. It looks like not all functions that return Task and are named *Async are in fact async in BricklinkClient. Is there a reason for this? Here is an example:

grafik

gebirgslok commented 1 year ago

The code needs a couple change to make the async hook work. It looks like not all functions that return Task and are named *Async are in fact async in BricklinkClient. Is there a reason for this? Here is an example:

grafik

You can make them async (but don't forget to await the HttpClient call) :)

gebirgslok commented 1 year ago

Thanks for your contribution! I'll release a 1.6.0 version tomorrow 👍