gebirgslok / BricklinkSharp

Easy-to-use C# client for the bricklink (LEGO) marketplace API.
https://github.com/gebirgslok/BricklinkSharp
MIT License
28 stars 12 forks source link

Added url parameter to request handler #20

Closed stephanstapel closed 1 year ago

stephanstapel commented 1 year ago

Hi @gebirgslok , how about adding a url parameter for more precise monitoring? In my case that would help a lot. However, I'm thinking about stripping the protocol and host part of the url (just passing the endpoint). What do you think?

Cheers, Stephan

gebirgslok commented 1 year ago

Maybe another Idea: instead of passing the url we could Pass a dedicated enum specifying the endpoint.

E.g. public enum BricklinkEndpoint

stephanstapel commented 1 year ago

Maybe another Idea: instead of passing the url we could Pass a dedicated enum specifying the endpoint.

E.g. public enum BricklinkEndpoint

I had a similar idea, shall I create a new class named BricklinkEndpointEnumerator for mapping url to enum?

gebirgslok commented 1 year ago

Maybe another Idea: instead of passing the url we could Pass a dedicated enum specifying the endpoint. E.g. public enum BricklinkEndpoint

I had a similar idea, shall I create a new class named BricklinkEndpointEnumerator for mapping url to enum?

I would keep it simple and just create an enum and pass it to the measureAsync method ( at that Point you know the endpoint already)

stephanstapel commented 1 year ago

@gebirgslok : Looking for your feedback on: