search

gebn / bmc_exporter

Exposes Baseboard Management Controller data in Prometheus format.
GNU Lesser General Public License v3.0
47 stars 3 forks source link

Exporter configuration flag rename for the secrets file? #72

Open ArKam opened 4 months ago

ArKam commented 4 months ago

Hi team

the exporter currently use the following configuration flag name for the secrets file integration: secrets.static and associated variable: secretsStatic as in: https://github.com/gebn/bmc_exporter/blob/master/bmc_exporter.go#L82

A better suited name would rather be: secrets.file and associated variable name: secretsFile

I know it's not really a big deal per see, but I think it's a plus for users/operators integration experience. thanks!

gebn commented 4 months ago

Hi @ArKam, thanks for this. The intention was to separate statically-provided secrets from those retrieved via some kind of integration, e.g. HashiCorp Vault. I know of at least one internal fork where a file is used to configure this integration, so --secrets.file would be ambiguous. Perhaps --secrets.static-file?

ArKam commented 2 months ago

That would be more explicit yep.

Or local-file and vault-file perhaps?