search

gebz97 / mandulis-ticketing-system

GNU General Public License v3.0
9 stars 8 forks source link

Feat/29 api pagination in tickets users and groups #44

Closed yencolon closed 2 months ago

yencolon commented 2 months ago

Now, pagination is available for Users, Tickets and Categories

gebz97 commented 2 months ago

Several things (I reviewed the changes)

  1. We're now using dev-0.1.0 to merge changes instead of directly to master
  2. There's already a builtin standard PageRequest in spring boot
  3. Transactional should be on the service layer not the controller layer
  4. Paging endpoints should be on a different path (/api/v1/public/tickets/paged for example) and not replace the existing functions

Other than that the work looks good, so just make those changes locally and commit again 👍

yencolon commented 2 months ago

Good. I was not aware of those changes, my bad.