gecche / laravel-multidomain

A Laravel extension for using a laravel application on a multi domain setting
MIT License
812 stars 99 forks source link

is it able to work with Octane? #55

Open arivelli opened 3 years ago

arivelli commented 3 years ago

Hey Folks,

I was able to put my project (which use laravel-multidomain) to work with octane (swoole), with no additional effort it is able to run cli commands. But when I try from web looks like only use the original .env file no matter the domain I use. Any suggestion to solve it?

Thank in advance

gecche commented 2 years ago

Hi,

sorry for the delay... I'm very very constrained in this period...

However, I never used Octane, so I'm not able to properly answer you... Anyway, since the CLI is working, maybe Octane does some customization in the App\Http\Kernel class or even in the main Illuminate\Foundation\Application class

But I don't have the code, so I'm only guessing

Cheers

Giacomo

arivelli commented 1 year ago

any news here?

gecche commented 1 year ago

nope… I’m sorry but I don’t use Octane so I’m not be able to help… I left the issue open but it seems nobody could help

cheers

giacomo

raulamoretti commented 1 year ago

I will test Octane + Swoole with multidomain! If somebody test before, call here!

negartarh commented 1 year ago

I will test Octane + Swoole with multidomain! If somebody test before, call here!

Hi What was the result of your test?

valsha commented 1 year ago

I will test Octane + Swoole with multidomain! If somebody test before, call here!

Hi, any news? Thanks.

raulamoretti commented 1 year ago

Hey guys!

In my initial tets it dont work. Only get original .env. I will commit in github my test.

Thanks!

valsha commented 1 year ago

@gecche any chance to add support Octane? Thank you.

fpolli commented 3 months ago

I think Octane support would require a massive change in architecture of the package. Octane splits off part of execution to run once and stay in memory. This package is based on the normal execution where the entire execution flow is run per request. I plan to use Octane with FrankenPHP so maybe I will fork the repo here and develop it for that paradigm. I need it anyway. It would be great if a more experienced coder were to do it, but...