gecche / laravel-multidomain

A Laravel extension for using a laravel application on a multi domain setting
MIT License
843 stars 105 forks source link

Updating env of a specific domain seems to update all .env files #67

Closed ccargill-ewx closed 2 years ago

ccargill-ewx commented 2 years ago

Hi,

this code has been really helpful in bridging the gap in our product however, looking at the documentation, either I am missing something or the parameter to specify which env file to update seems to get ignored and proceeds to update all files?

php artisan domain:update_env --domain=testdomain.com --domain_values='{"TOM_DRIVER":"TOMMY"}' is how i assumed this would be structured, so am I missing something?

Many thanks!

nettsite commented 2 years ago

Does the same for me.

Best regards,

William Nettmann Office: 010 013 0525 Mobile: 082 309 4007

[image: Facebook] https://www.facebook.com/NettSite [image: Twitter] https://twitter.com/NettSiteCoZa [image: Google+] https://plus.google.com/+NettsiteCoZa [image: LinkedIn] http://www.linkedin.com/company/1082367?trk=tyah&trkInfo=tas%3Anettsite%2Cidx%3A1-1-1

On Thu, 13 Jan 2022 at 14:40, ccargill-ewx @.***> wrote:

Hi,

this code has been really helpful in bridging the gap in our product however, looking at the documentation, either I am missing something or the parameter to specify which env file to update seems to get ignored and proceeds to update all files?

php artisan domain:update_env --domain=testdomain.com --domain_values='{"TOM_DRIVER":"TOMMY"}' is how i assumed this would be structured, so am I missing something?

Many thanks!

— Reply to this email directly, view it on GitHub https://github.com/gecche/laravel-multidomain/issues/67, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACYESU3GZYDKG7IF3INTPO3UV3B37ANCNFSM5L3XAG7A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

gecche commented 2 years ago

Hi all,

I will check asap the issue. Actually, I never use that command :) I thought about dropping it in future release but it seems that some of you are using it, so I will keep it in the package :)

Could you tell me which version are you using?

Cheers

Giacomo

ccargill-ewx commented 2 years ago

Hi thanks for getting back. Yes please keep this in the release its really helpful for one of our products! We are using the latest version with Laravel 8.

Many thanks

gecche commented 2 years ago

Hi all,

I haven't had time to try yet, but re-reading your messages, I think that there is only a "bug" in the documentation! :) If you want to update only one specific env file, you should specify the domain name as an argument and not as an option (as wrongly written in the docs):

php artisan domain:update_env testdomain.com --domain_values='{"TOM_DRIVER":"TOMMY"}'

Let me know if it works properly (I think yes)... I will update the docs accordingly

Cheers

Giacomo

gecche commented 2 years ago

Hi, as I have not received more comments yet, I just updated the docs and close the issue

Cheers

Giacomo