geco-bern / FluxDataKit

LEMONTREE flux data kit
https://geco-bern.github.io/FluxDataKit
2 stars 11 forks source link

the unit of model gpp and EC-gpp seems not the same #31

Closed lypluo closed 1 year ago

lypluo commented 1 year ago

Hi Koen,

I was trying to compare the EC-based GPP from CH-Dav and p-model simulated GPP. It seems the values of EC GPP are much higher compared to modeled EC. I am wondering what's the unit of EC GPP and p-model GPP? The simulated GPP by the p-model followed the same model parameterization as Stocker et al., 2020?

Best test

stineb commented 1 year ago

This concerns the documentation of units in arguments and outputs of the function you used to run the P-model. Is this rsofun or rpmodel? It is all documented for rpmodel here. For rsofun, it's not transparent enough. I'm closing this issue and raising one to clarify units in rsofun.