search

geco-bern / agds

Applied Geodata Science book. Developed for the lecture(s) with the same name at the Institute of Geography, University of Bern.
https://geco-bern.github.io/agds/
Other
5 stars 6 forks source link

Created images don't render on GitHub #70

Closed stineb closed 1 year ago

stineb commented 1 year ago

Images created on-the-fly by code chunks don't render with gh-pages and don't show up in the online book. They do show when compiled locally and with serve_book(). This may be related to this issue, and may be solvable by adding a .nojekyll file in the gh-pages branch (see here). @khufkens does this sound reasonable?

khufkens commented 1 year ago

Fork to your personal account and try these settings, if functional do a pull request. Check the origin of the images and if they are included in the gh-pages branch, also check the url of the images for validity.

On Mon, Feb 20, 2023, 07:51 Benjamin Stocker @.***> wrote:

Images created on-the-fly by code chunks don't render with gh-pages and don't show up in the online book. They do show when compiled locally and with serve_book(). This may be related to this issue https://github.com/rstudio/bookdown/issues/1087, and may be solvable by adding a .nojekyll file in the gh-pages branch. @khufkens https://github.com/khufkens does this sound reasonable?

— Reply to this email directly, view it on GitHub https://github.com/geco-bern/agds/issues/70, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKKUEWAL5MCELKGPEVEZETWYMH6HANCNFSM6AAAAAAVBPWUOI . You are receiving this because you were mentioned.Message ID: @.***>

khufkens commented 1 year ago

.nojekyll works testing persistence

khufkens commented 1 year ago

persistent

khufkens commented 1 year ago

Closed issues are always resolved @stineb (or the decision is made not to resolve it - won't fix / or design choice, this should be reflected in the comments).

All resolved issues should also be closed on the issue list, which there are now some (this is not Notion). If you need to consult previous issues you search for them by searching both closed and open issues (by default only open issues are shown).