geco-bern / map2tidy

https://geco-bern.github.io/map2tidy/
GNU Affero General Public License v3.0
1 stars 1 forks source link

Failure on check() #4

Closed stineb closed 2 months ago

stineb commented 2 months ago

Running

devtools::check()

Returns with error message:

E  Some test files failed
   Running the tests in ‘tests/testthat.r’ failed.
   Last 13 lines of output:
         ~map2tidy::nclist_to_df_byilon(nclist, ., outdir, fileprefix, 
             varnam, lonnam, latnam, timenam, fgetdate, overwrite), 
         .progress = TRUE))`: ℹ In argument: `out = purrr::map(...)`.
     Caused by error in `purrr::map()`:
     ℹ In index: 1.
     Caused by error in `purrr::map()`:
     ℹ In index: 1.
     Caused by error in `dplyr::mutate()`:
     ℹ In argument: `datetime = CFtime::as_timestamp(...)`.
     Caused by error:
     ! 'as_timestamp' is not an exported object from 'namespace:CFtime'

     [ FAIL 1 | WARN 0 | SKIP 0 | PASS 0 ]
     Error: Test failures
     Execution halted
fabern commented 2 months ago

Okay, this appears to be linked to an old version of package CFtime. I'll check where it works and where it fails.

Did you run this locally? What is packageVersion("CFtime")?

stineb commented 2 months ago

Mine is 1.4.0

fabern commented 2 months ago

I close this now, since this works on the Github CI. Feel free to reopen if somewhere locally it is still not working.