gecos-lab / PZero

GNU Affero General Public License v3.0
24 stars 2 forks source link

creating cross-sections #86

Open andrea-bistacchi opened 2 months ago

andrea-bistacchi commented 2 months ago

Methods to create cross-sections must me corrected and made more logical.

Functions and classes to be reviewed are:

XSectionCollection

sections_from_file

section_from_azimuth

gocad2vtk_section (this one in gocad2vtk module)

Probably adding in XSectionCollection a method (or some methods) to update metadata and geometry from redundant values when others are known will help avoiding a lot of code repetition.

andrea-bistacchi commented 2 months ago

Also section_from_azimuthmust be reviewed because the end point here must be calculated from azimuth and length/width.

andrea-bistacchi commented 2 months ago

Also to check: