Open andrea-bistacchi opened 2 months ago
Also section_from_azimuth
must be reviewed because the end point here must be calculated from azimuth and length/width.
Also to check:
length
vs width
vs height terminology
, also for inclined sections
strange behavior of get_XY_from_W
, get_deltaXY_from_deltaW
, plane2world
.
Methods to create cross-sections must me corrected and made more logical.
Functions and classes to be reviewed are:
XSectionCollection
sections_from_file
section_from_azimuth
gocad2vtk_section (this one in gocad2vtk module)
Probably adding in
XSectionCollection
a method (or some methods) to update metadata and geometry from redundant values when others are known will help avoiding a lot of code repetition.