gecrooks / weblogo

WebLogo 3: Sequence Logos redrawn
weblogo.threeplusone.com
Other
146 stars 39 forks source link

add a conda install option #124

Closed sugatoray closed 2 years ago

sugatoray commented 2 years ago

It will be nice to have a conda install option along side the ability to install with pip from PyPI.

I have already started the work of adding weblogo to conda-forge channel on conda. (PR: https://github.com/conda-forge/staged-recipes/pull/17283). Once the library is available on conda-forge, you can install it as follows:

conda install -c conda-forge weblogo

Note: the conda package depends (builds from source) on the PyPI released version (tar.gz file) on weblogo.

sugatoray commented 2 years ago

cc: @ghuls @gecrooks

ericmjl commented 2 years ago

@sugatoray I believe weblogo is installable via bioconda rather than conda-forge. If so, you might be able to save yourself a bit of work :smile:. @ghuls and @gecrooks could you confirm, please?

gecrooks commented 2 years ago

There does seem to be a bioconda install, https://anaconda.org/bioconda/weblogo

Worth adding a note to the installation instructions.

sugatoray commented 2 years ago

@ericmjl Thanks for mentioning bioconda channel as an option. However, I am not sure if a package from bioconda channel can be used while packaging up for conda-forge channel. As far as my understanding goes about conda-forge, you can only include packages from the channel itself as dependencies. There is a way out only in case your dependencies are optional. In that case you could use run_constrained for the optional dependencies, while creating the conda-forge package.

sugatoray commented 2 years ago

Update

cc: @ericmjl @ghuls @gecrooks

I received a green light from bioconda core team to port weblogo recipe from bioconda over to conda-forge. So, after porting is done, the weblogo recipe will be maintained under conda-forge. Bioconda inherits packages from conda-forge. Hence, in order to avoid duplication, the porting is necessary. Thus, anyone using bioconda to package some library which requires weblogo, will still have weblogo available (inherited from conda-forge).

License related problem for weblogo :fire:

cc: @ghuls @gecrooks

However, there seems to be a problem with wblogo's license. The repository states it's available under MIT License. But the setup.py states it's available under BSD license. Which one is it?

I opened another issue to specifically track this: https://github.com/WebLogo/weblogo/issues/131

go-bears commented 2 years ago

@sugatoray

131 was resolved and closed. Do you still need any more information to complete the port to conda-forge?

sugatoray commented 2 years ago

Thank you. No, the porting was successful a few months ago. No other immediate requirements as of now.

go-bears commented 2 years ago

great to hear!

thanks for taking that on!