search

gedankenexperimenter / Kaleidoscope

Firmware for the Keyboardio Model 01 and other keyboards with AVR or ARM MCUs.
http://keyboard.io
GNU General Public License v3.0
0 stars 1 forks source link

Change names of Key variants #22

Closed gedankenexperimenter closed 6 years ago

gedankenexperimenter commented 6 years ago

It looks like something isn't right with the names of the Key variant classes (e.g. Key::Keyboard). I still think those names are helpful, but they appear to result in linker errors if any of their functions are defined in a separate *.cpp file (which means that all functions must be inlined, which may be best anyway, but…), so it looks like I'll have to rename them. Key::Keyboard will become KeyboardKey, et cetera. This means that the existing LayerKey class needs to be renamed (no big deal – I wasn't happy with that name, anyway, and it probably should just be defined in the Keymap file, anyway, and any functions that use it can be private.

gedankenexperimenter commented 6 years ago

In addition, I want to rename all the testType(key) functions to verify(key)