search

geddski / grunt-release

Release a new version of your Node-based project
MIT License
389 stars 121 forks source link

update all dependencies #151

Closed marcobiedermann closed 8 years ago

marcobiedermann commented 8 years ago

Update dependencies

drublic commented 8 years ago

@marcobiedermann Can you please look at this again? Checks failed.

dorgan commented 8 years ago

I'll look at pulling ths in once we get the test task working again. Please stand by...

Issue: #152

dorgan commented 8 years ago

@marcobiedermann if you will update these to the latest current versions, I will go ahead and pull this in. Thank you for contributing!

dorgan commented 8 years ago

@drublic his checked we're failing because of bad code already in the module. (see commit that corrects bad code here)

drublic commented 8 years ago

Thanks for fixing this @dorgan.

marcobiedermann commented 8 years ago

@drublic @dorgan I've merged the updated master branch into my feature and updated all dependencies again. Hope, this will fit all your needs. If you got any more suggestions, feel free to hit me up :)

dorgan commented 8 years ago

@marcobiedermann looks like upgrading to latest dependencies breaks somethings as tests are failing.

marcobiedermann commented 8 years ago

@dorgan When I run grunt test I get the following output:

Running "setup:test" (setup) task
Warning: Path must be a string. Received [ 'test/fixtures/component.json' ] Use --force to continue.

Honestly I do not have any idea how to solve this. I googled a bit but could not find the right answer.

dorgan commented 8 years ago

I'm actually working through this now. I've solved that problem as well as another and now am working on the third, and then I believe there is a fourth. Hopefully I'll be able to get these resolved soon.

On Sunday, May 1, 2016, Marco Biedermann notifications@github.com wrote:

@dorgan https://github.com/dorgan When I run grunt test I get the following output:

Running "setup:test" (setup) task Warning: Path must be a string. Received [ 'test/fixtures/component.json' ] Use --force to continue.

Honestly I do not have any idea how to solve this. I googled a bit but could not find the right answer.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/geddski/grunt-release/pull/151#issuecomment-216046062

dorgan commented 8 years ago

Based on the complexities of the changes I am having to be compatible, this will have to wait for the next release, as there will be breaking changes in this.

On Sunday, May 1, 2016, Donald Organ dorgan@donaldorgan.com wrote:

I'm actually working through this now. I've solved that problem as well as another and now am working on the third, and then I believe there is a fourth. Hopefully I'll be able to get these resolved soon.

On Sunday, May 1, 2016, Marco Biedermann <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

@dorgan https://github.com/dorgan When I run grunt test I get the following output:

Running "setup:test" (setup) task Warning: Path must be a string. Received [ 'test/fixtures/component.json' ] Use --force to continue.

Honestly I do not have any idea how to solve this. I googled a bit but could not find the right answer.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/geddski/grunt-release/pull/151#issuecomment-216046062

moczolaszlo commented 8 years ago

Hi @dorgan and @marcobiedermann I fixed the testes, all passed for me with the updated dependencies. Tomorrow I will send a PR to this repo, ok?

moczolaszlo commented 8 years ago

Here: https://github.com/geddski/grunt-release/pull/156

dorgan commented 8 years ago

Resolved in #156