geddski / macros

macros support for VS Code
MIT License
165 stars 36 forks source link

keybinding fail #51

Open Gubith opened 5 years ago

Gubith commented 5 years ago

keybinding problem with "Macros.commentDown" The error is "Value is not accepted. Valid values: ..." Currently no other problems showing in all of vsCode.

My custom macros were failing this way so I removed all that and put only examples from the info page.

keybindings.json
    { "key": "alt+d", "command": "Macros.commentDown"   },

settings.json
"macros": {
    "commentDown": [
        "editor.action.copyLinesDownAction",
        "cursorUp",
        "editor.action.addCommentLine",
        "cursorDown"
    ]
},
oloryn commented 4 years ago

Just installed macros on the latest VSCode (1.40.1), and I'm seeing the same problem. With macros not being added to the command palette, and keybindings now not working, this extension doesn't seem to be useful.

oloryn commented 4 years ago

See @jeff-hykins's macro-commander, a fork of this extension which fixes this and works on the current version of VSCode.