geddski / macros

macros support for VS Code
MIT License
165 stars 36 forks source link

macro doesn't appear to be executing mysql.query step in defined sequence #66

Open myusrn opened 1 year ago

myusrn commented 1 year ago

I have the following settings.json macros mysqlQueryAndCursorDown setting defined and associated keybindings.json keyboard shortcut in place to execute it. When i do the mysql.query command doesn't appear to be executed and the cursorDown step does.

Is there an issue here with how i defined the macros entry or perhaps something to do with macros extension execution of that mysql extension step?

I opened an issue on the mysql extension side of things cweijan/vscode-database-client/issues/840 and over there its being stated that this command works, as confirmed by the out of the box keyboard shortcut it provides, ctrl+enter, executing it as expected. Thinking is that perhaps macros extension is

"macros": { 
        "pythonExecSelectionAndCursorDown": [ "python.execSelectionInTerminal", "cursorDown" ],
        "mysqlQueryAndCursorDown": [ "mysql.query", "cursorDown" ] 
    }
[
  { "key": "ctrl+enter", "command": "macros.pythonExecSelectionAndCursorDown", "when": "editorTextFocus && editorLangId == 'python'" },
  { "key": "shift+enter", "command": "macros.mysqlQueryAndCursorDown", "when": "editorTextFocus && editorLangId == 'sql'" }
]