search

geddy / model

Datastore-agnostic ORM in JavaScript
265 stars 55 forks source link

fixed reconnection problem #164

Closed eden-lane closed 10 years ago

eden-lane commented 10 years ago

It seems to be working according to my manual tests. I will write an automatic tests, as soon as I learn how to do it.

mde commented 10 years ago

It looks like this breaks the automated tests. We'll have to get automated tests running with this before we can merge it.

eden-lane commented 10 years ago

My sincere apologies. I will try to find a reason.

mde commented 10 years ago

No need to close the PR. :) Let's just get it fixed and working. Please reopen it if you'd like to fix this!

ben-ng commented 10 years ago

@edencore what broke in the automated tests?

eden-lane commented 10 years ago

@mde oh, sorry. Still in the middle of comprehending all that PR-system :) @ben-ng I have no idea, to be honest. If I understand it correct, there is AssertionError, but that can't be blame of my changes. I have to read more about Travis CI first. That's my plan for now.

eden-lane commented 10 years ago

Hm. Now it is "All is well".

ben-ng commented 10 years ago

Oh, looks like you just had to merge in an eager association fix. Nice!

eden-lane commented 10 years ago

Great, thanks !