search

geddy / model

Datastore-agnostic ORM in JavaScript
265 stars 55 forks source link

Addjusting Example of Documentation for using model with postgres adapter #180

Closed ghost closed 10 years ago

ghost commented 10 years ago

Hello everyone!

I was just using geddy/model for the first time ever and encountered an inconsistency in the documentation. For further details and reference please see Issue #179.

Thanks and take care, Dennis

mde commented 10 years ago

Ugh, I'm sorry I merged this prematurely. Basically the reason the naming conventions are all different is because the underlying DB libs all use different names for these things. We just pass the config off to the DB lib. This PR was breaking our test suite.

I think we should fix this problem by writing a small layer that normalizes the terms so that we can use consistent naming in the configs, but the DB libs will be happy too. (For example, it should accept either 'dbname' or 'database' and then pass the correct name to the underlying DB lib.)

I kept your fix to the README, but I've reverted the other change. Could you open a new PR so we can work together to put together this better fix?

Thanks!