search

gedex / wp-better-hipchat

This plugin allows you to send notifications to HipChat rooms when certain events in WordPress occur
http://wordpress.org/plugins/better-hipchat/
GNU General Public License v2.0
17 stars 3 forks source link

Support rooms with spaces in their names (and other special characters) #2

Closed myquealer closed 10 years ago

myquealer commented 10 years ago

Without this HipChat just returns a "Bad Request" 400 status if the room name contains a space.

gedex commented 10 years ago

@myquealer Thanks for this! I'll deploy this to WP.org.

Do you have WP.org profile so that I can put your username in contributors list?

myquealer commented 10 years ago

Askeda,

Wp.org username is myquealer

Btw I had to use rawurlencode instead of urlencode to change spaces to %20 instead of +. HipChat returned "Room not found" if spaces were replaced with +.

Mike

On Friday, September 12, 2014, Akeda Bagus notifications@github.com wrote:

@myquealer https://github.com/myquealer Thanks for this! I'll deploy this to WP.org.

Do you have WP.org profile so that I can put your username in contributors list?

— Reply to this email directly or view it on GitHub https://github.com/gedex/wp-better-hipchat/pull/2#issuecomment-55377640.

Mike Wheeler Palo Alto Software Inc. www.liveplan.com | www.bplans.com | www.paloalto.com