search

gediminasel / videospeed-firefox

HTML5 video speed controller (for Firefox). WebExtensions port of Video Speed Controller Chrome extension.
MIT License
23 stars 2 forks source link

Microsoft video-playback is broken #1

Closed PhymIsBored closed 1 year ago

PhymIsBored commented 1 year ago

The video does not show video with the addon enabled, sound plays normally.

https://www.microsoft.com/en-us/videoplayer/embed/RWfonD?pid=ocpVideo1-innerdiv-oneplayer&jsapi=true&maskLevel=20&market=en-us

gediminasel commented 1 year ago

Hi, thanks for reporting. This is a known issue from the Chrome extension (e.g. https://github.com/igrigorik/videospeed/issues/936). It occurs on sites that use :first-child selector to style video because the controller node is inserted before it. It would be best to have an upstream fix in https://github.com/igrigorik/videospeed. I might implement a workaround: e.g. have a list of domains where the controller should be inserted after the video.

gediminasel commented 1 year ago

Hi, I pushed a workaround. Please update (0.7.4) and let me know if it works and if it breaks something else.

PhymIsBored commented 1 year ago

Works for me. Thank you