search

gediminasz / ctags-companion

A Visual Studio Code symbols provider based on Ctags
https://marketplace.visualstudio.com/items?itemName=gediminaszlatkus.ctags-companion
MIT License
25 stars 7 forks source link

there is a bug when .tags file contains "hasOwnProperty" or other built in object property names #15

Closed ocoka closed 2 years ago

ocoka commented 2 years ago

here https://github.com/gediminasz/ctags-companion/blob/master/src/index.js#L47 steps to reproduce: create new js project somethere in code define hasOwnProperty as method index project

gediminasz commented 2 years ago

Thanks for the report!

I will try and reproduce the issue but I think I can fix this using Map instead of a plain old object.

ocoka commented 2 years ago

Hi,

I will try and reproduce the issue but I think I can fix this using Map instead of a plain old object.

Indeed, i think that will be the fastest way to fix

ocoka commented 2 years ago

And I've missed the line where the bug occurs, here https://github.com/gediminasz/ctags-companion/blob/master/src/index.js#L47 also edited in my comment above thx, for you time and work

gediminasz commented 2 years ago

I have just published a new version to vscode marketplace. Let me know if the issue persists.

ocoka commented 2 years ago

thx. it works now