search

gedion / ep_tables

Datatable plugin for etherpad-lite
12 stars 10 forks source link

Porting to LiveScript, and fixing a few blocker bugs #6

Open audreyt opened 12 years ago

audreyt commented 12 years ago

This fixed a few blocker issues:

It would be nice if we can allow inline styles (bold/italic/underline) within a table cell, but I think it's a good checkpoint for you to consider merging.

Thank you for the great initial work!

gedion commented 12 years ago

Hello. This is pretty amazing. Thank you for taking your time and for suffering through the maze. I'm really excited on how much you have cleaned it up. I don't have much familiarity with LiveScript but I'll still go through the implementation and send feedback.

Here are some initial test cases that broke the pad. 1) is a new error I believe. 2) also exists in original implementation. However the stuck in 'Loading...' state is new I believe.

1) Entering a url (example: https://www.google.com) within a cell causes a 'Uncaught SyntaxError: JSON.parse: "," "]],"tblId":"1","tblClass":"\ufff9"}' error. Refreshing the pad leaves the 'Loading...' state

2) Highlighting more than one cell and deleting them causes erotic behavior that includes continues new line with text entry in the pad and caret position jumping. Refreshing the pad leaves the 'Loading...' state

I will do a more thorough testing in the coming days.

audreyt commented 12 years ago

Thanks, 1) was fixed by clkao in 9a3e7fe... As re 2), we've observed the erratic behavior as well. The workaround for now I guess is to disallow the delete keys when selection spans multiple cells?

clkao commented 12 years ago

Note that for 2) it's basically keyevent (replace or delete) needs to check for user selection with the same logic of isCellDeleteOk