gee-community / geetools

A collection of tools to work with Google Earth Engine Python API
https://geetools.readthedocs.io/en/stable/
MIT License
504 stars 121 forks source link

fix: correct import statement in batch #204

Closed 12rambau closed 5 months ago

12rambau commented 5 months ago

attempt to fix #201

This is a firefighter move before we start refactoring the batch methods. this package is still making relative imports from files that no longer exist in the lib. I think I corrected the 2 occurences but I'll need to be extra careful in my next modifications.

@Shima-shoki would you mind trying this branch in your code to check if there are no other import issues down the road ?

Simply run this in a previous cell:

!pip install 'geetools @ git+https://github.com/gee-community/geetools@batch'
codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b1b327a) 36.47% compared to head (c2dd92f) 36.47%. Report is 1 commits behind head on main.

Files Patch % Lines
geetools/batch/image.py 0.00% 1 Missing :warning:
geetools/batch/imagecollection.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #204 +/- ## ======================================= Coverage 36.47% 36.47% ======================================= Files 52 52 Lines 2925 2925 Branches 296 296 ======================================= Hits 1067 1067 Misses 1853 1853 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Shima-shoki commented 5 months ago

@12rambau Thank you very much for your prompt response to the issue! The following command you kindly shared worked fine to resolve the problem.

!pip install 'geetools @ git+https://github.com/gee-community/geetools@batch'

After executing above code in my Colab environment, the "batch" module looks successfully imported from geetools version 1.0.0 as shown in the attached screenshot. image

12rambau commented 5 months ago

@Shima-shoki happy to hea! Then let me include this in the next patch release and you will be able to use latest published version without my little custom branch.