geek-ai / MAgent

A Platform for Many-Agent Reinforcement Learning
MIT License
1.68k stars 332 forks source link

Fix a bug #40

Closed TimerChen closed 5 years ago

TimerChen commented 5 years ago

Add the initialization of NUM_SEP_BUFFER

merrymercy commented 5 years ago

We don't need this. NUM_SEP_BUFFER is set here https://github.com/geek-ai/MAgent/blob/872680a8b9fee02c527306e65c4aeee1641b11a5/src/gridworld/GridWorld.cc#L77-L81

You should always call env.reset() before other operations to the env.

TimerChen commented 5 years ago

https://github.com/geek-ai/MAgent/blob/872680a8b9fee02c527306e65c4aeee1641b11a5/src/gridworld/GridWorld.cc#L75-L84 @merrymercy It still have problem, if width * height <= 99*99, then NUM_SEP_BUFFER would not be initlized. Now I have moved this initialization, fixed some bugs in python, and made some little modifications in render/frontend.

merrymercy commented 5 years ago

@TimerChen Thanks. It is merged.