Making payment method independent from currency

geek-at / phptrader

A simple php powered Bitcoin and Ethereum trading bot

143 stars 41 forks source link

Closed daryledesilva closed 7 years ago

daryledesilva commented 7 years ago

Hi,

I made a new payment method name definition in the config file so payment method logic doesn't rely on currency.

In my setup payment method name is completely different from the pattern you've setup (w/c is CURRENCY + ' Wallet')

Mine is something like "Xfers Account: [MY PHONE NUMBER]"

so i guess it would be better to just let the user specify this as a separate setting.

geek-at commented 7 years ago

great work! Thought that sooner or later someone who renamed their wallets will send this pull request ;D

But we need legacy support so users who upgrade won't have to change their config (they never do)

daryledesilva commented 7 years ago

Thanks @chrisiaut for the feedback. I have updated my PR. Please let me know if more adjustments are needed for legacy support

Kickball commented 7 years ago

@chrisiaut has this PR been reviewed?

geek-at commented 7 years ago

Seems good, yes