search

geekdeepak / gdata-ruby-util

Automatically exported from code.google.com/p/gdata-ruby-util
Apache License 2.0
0 stars 0 forks source link

Does not respond to conditional GET request 304 #16

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. A request cannot be made in the current state with an HTTP header that 
includes ['If-None-Match']. 

What is the expected output? What do you see instead?

It is expected that 304 is returned during a conditional GET.

What version of the product are you using? On what operating system?
gdata-ruby-util-1.1.2

OS 10.7
Please provide any additional information below.

Original issue reported on code.google.com by rickschm...@gmail.com on 21 Jul 2011 at 1:40

GoogleCodeExporter commented 9 years ago 
The fix is to change line 84 in /lib/gdata/client/base.rb to include 304 as a 
possible response code. 

 case response.status_code  
        when 200, 201, 302, 304
          #Do nothing, it's a success.

Original comment by rickschm...@gmail.com on 21 Jul 2011 at 3:05