search

geekduck / atom-image-resize

A resize plugin for image files and base64 encoded images
MIT License
3 stars 0 forks source link

Promise.done is deprecated. #6

Open dazedpro opened 7 years ago

dazedpro commented 7 years ago

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1203:5)
Object.toggle (/Users/cmarsh/.atom/packages/atom-image-resize/lib/main.coffee:85:10)
atom-workspace.subscriptions.add.atom.commands.add.atom-image-resize:toggle (/Users/cmarsh/.atom/packages/atom-image-resize/lib/main.coffee:18:26)
CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:259:29)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:59)
CommandPaletteView.confirmed (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/command-palette/lib/command-palette-view.js:210:32)
m7md3omr commented 7 years ago

same here !!

ericmacedo commented 7 years ago

It seems to work just fine. But the deprecation message persist.