search

geekelo / domins-recipe_app

The Recipe app keeps track of all your recipes, ingredients, and inventory.
2 stars 1 forks source link

Milestone: Created Kanban board #11

Closed geekelo closed 11 months ago

geekelo commented 11 months ago

Link to Kanban here for a team of 2: @Bleu-Yves-Sopoude @geekelo

zieeco commented 11 months ago

Hi @Team,

Fantastic setting up the kanban board for your project 👏 You've done well implementing some of the changes, however, there are some issues that you still need to work on to go to the next project, but you are almost there!

To highlight 🎯

Required Changes ♻️

Check the comments below.

Optional suggestions

_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application._

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TedLivist commented 11 months ago

STATUS: CHANGES REQUIRED ♻️ ♻️

Hi @geekelo and @Bleu-Yves-Sopoude,

Good job so far! ✔️ Kanban columns are complete ✔️ Tasks are well-assigned However, there are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. And please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

TuyishimireEric commented 11 months ago

Status: APPROVED 🟢

Hi @TEAM 👋 👋

I'm @TuyishimireEric, Your code reviewer,

Good job on implementing the project requirements! 🥇 done

Your project is complete! There is nothing else to say other than... it's time to merge it 🦾
Congratulations! 🎉

Highlight 👍

✅ Kanban columns are complete 👍 ✅ Made suggested changes 👍

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.