search

geekflyer / gulp-ui5-preload

Create a Component-preload.js file for openui5 / sapui5 projects
33 stars 10 forks source link

Generate library-preload.js #8

Open StErMi opened 7 years ago

StErMi commented 7 years ago

I think it could be a good thing to generate a library-preload.js like in grunt-openui5 https://github.com/SAP/grunt-openui5/pull/47

Kyrodan commented 6 years ago

Are there any news on this issue? Maybe I could implement this and send a PR?

geekflyer commented 6 years ago

@Kyrodan I'm actually not working on ui5 anymore and hence I'm very open for someone else to become maintainer of this repo (and the npm package). I can give you collaborator rights to the repo if you want.

jomaguma commented 6 years ago

I fixed the issue in #10.

cschuff commented 6 years ago

You can use the SAPUI5 configuration option xx-libraryPreloadFiles to prevent the default request to library-preload.js and make SAPUI5 load the .json file instead. Will be looking into your pull request as soon as possible.

jomaguma commented 6 years ago

Thanks for the link, didn't know about that option. However, I'd like to use the .js files instead since it's the default in newer versions. I've been invited to contribute and could merge myself now, but I'll leave the PR open for your review.