search

geekforbrains / caffeine

A simple PHP framework that combines modules through the use of routes and events to form an application.
http://geekforbrains.com
MIT License
15 stars 1 forks source link

Language Code #4

Open Wemago opened 12 years ago

Wemago commented 12 years ago

You've blocked language code to 3 letters. Don't do this, you should use the i8n code, ex: en, en-us or pt-pt, pt-br

And the minimum shouldn't be three. en, fr, pt, etc are all two letters.

will it be possible to translate urls?

geekforbrains commented 12 years ago

Thanks for the tip! I'll look into changing the language codes to i8n format.

I'm not sure what you mean by translate urls? The way it works now is if you prepend a url with a language code, Caffeine will automatically get translations (if they exist) for content on that page.

Example:

/page/about-us -> Gets regular about us page in default language it was written in /spa/page/about-us -> Gets the about us page with any translations for the "spa" language

Wemago commented 12 years ago

Translating url would be something like this

/page/about-us -> default /pt-pt/página/sobre-nós -> translation

geekforbrains commented 12 years ago

Ah ok, I dont have anything like that planned right now, but definitely something to look at for the future.

Wemago commented 12 years ago

I think it wouldn't be to hard to implement since you have everything setup already.

The only two things that needs to be changed is router to be able to find translated url and the menu class for translated slugs.

geekforbrains commented 12 years ago

Yes, thats true. However, Id want to put more thought into it before tackling translated URLs / menus. The multilang module itself is still in development and a bit unstable. However, id still like to add this functionality.

Wemago commented 12 years ago

I've been playing around with this new version of caffeine/chubby, I'm in love with it. I see huge potential in this.

Since you are developing the multilang module why not apply to it something like this http://code.google.com/p/simplepo/ You already have the interface and db part somewhat done.

geekforbrains commented 12 years ago

Glad you like the framework so far. :) I've never used SimplePO, I'll have to check it out.