search

geekhybrid / vue3-tree-vue

MIT License
63 stars 22 forks source link

Added CSS to terminate vertical lines #16

Closed berge472 closed 1 year ago

berge472 commented 1 year ago

I updated the style sheet to terminate the vertical Guidelines at the last node in each branch

image

geekhybrid commented 1 year ago

Lovely.

geekhybrid commented 1 year ago

Hi, @berge472 can you please have a look at the left border?

Before

image

After

image
berge472 commented 1 year ago

I pushed a change that should fix this. I am having a hard time testing though. Normally when I work on a package I can use 'npm link ../project/path' to use the local version while I develop, but when I do that with this package I get the error "resolveComponent can only be used in render() or setup().". Is there something I need to do when I build to allow it to be linked?

On Mon, Oct 2, 2023 at 6:47 AM Francis Enyi @.***> wrote:

Hi, @berge472 https://github.com/berge472 can you please have a look at the left border?

Before [image: image] https://user-images.githubusercontent.com/39003759/271949887-5bc2ea06-8929-48f8-8978-2dc14d3998ab.png

After [image: image] https://user-images.githubusercontent.com/39003759/271949722-cd00ad81-76fd-4dcd-8baf-ee12b533b80e.png

— Reply to this email directly, view it on GitHub https://github.com/geekhybrid/vue3-tree-vue/pull/16#issuecomment-1742791381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3YQ6PA2VUNLYIOI4GK4W3X5KLSZANCNFSM6AAAAAA5LEPZQM . You are receiving this because you were mentioned.Message ID: @.***>

geekhybrid commented 1 year ago

Thanks for looking at this.

You can run npm run serve on the project. It starts up a project that has HMR and uses the current state of the code. Hope it helps.